Merged
Conversation
methylDragon
force-pushed
the
runtime_interface_reflection
branch
2 times, most recently
from
0ea7129 to
3c323f3
Compare
31 tasks
methylDragon
force-pushed
the
runtime_interface_reflection
branch
3 times, most recently
from
6956703 to
d7fb25f
Compare
methylDragon
force-pushed
the
runtime_interface_reflection
branch
6 times, most recently
from
721768e to
274b471
Compare
methylDragon
force-pushed
the
runtime_interface_reflection
branch
3 times, most recently
from
bf1434d to
a4c386d
Compare
methylDragon
force-pushed
the
runtime_interface_reflection
branch
12 times, most recently
from
475c5da to
38b3d5a
Compare
methylDragon
force-pushed
the
runtime_interface_reflection
branch
from
37690a5 to
46379ff
Compare
wjwwood
reviewed
Apr 6, 2023
wjwwood
reviewed
Apr 6, 2023
wjwwood
reviewed
Apr 6, 2023
methylDragon
force-pushed
the
runtime_interface_reflection
branch
from
dcd98f4 to
2ab3722
Compare
wjwwood
requested changes
Apr 7, 2023
Member
wjwwood
left a comment
wjwwood
left a comment
There was a problem hiding this comment.
We have some interfaces to remove/move, but otherwise lgtm
wjwwood
approved these changes
Apr 8, 2023
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
wjwwood
force-pushed
the
runtime_interface_reflection
branch
from
4de8ad6 to
31f89e8
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the runtime interface reflection subscription feature of REP-2011: ros2/ros2#1374
Description
This PR includes changes to the RMW APIs for supporting runtime interface reflection, namely.
rosidl_message_type_support_tWith also new interfaces for: